GitLab

Previously, we just inspected sizes to tell if the linker was stripping
unnecessary bits, so, actually look for symbols.

Fixes golang/go#34209

Change-Id: Iec355ac46a967aeca9c0c1a950ead6b563c5e84e
Reviewed-on: https://go-review.googlesource.com/c/text/+/221104


Run-TryBot: Jeremy Faller <jeremy@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

When (d *dictionary) Lookup() is called on an non-existing key, the
`messageKeyToIndex[key]` returns 0. As 0 is also a valid entry in
messageKeyToIndex, the method returned the wrong value rather than fail.

Fixes golang/go#35587

Change-Id: Iedd1cf42f29335c2c2052b07993d7f2dfcd3cc6c
Reviewed-on: https://go-review.googlesource.com/c/text/+/207217


Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

When using gotext utility, the output files are always reshuffled,
which makes any kind of source versioning and incremental translation
a real challenge.

This commit sorts the Go files by package name and order index (file
name is not available) before processing the string extraction.

Furthermore, an issue with sorting plural cases has been resolved.
Originally, it sorted ["two", "few", "one", "other"] wrong.

Fixes golang/go#33552

Change-Id: I76fc5d40cf4f989e01ba6d897c0a69029ca30337
Reviewed-on: https://go-review.googlesource.com/c/text/+/207281


Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

If this test is run as a dependency of some other module, the testdata
directory will be read-only. Moreover, if temporary files are written
to the working directory they are likely to interfere with concurrent
version-control operations, such as 'git commit -a'.

Updates golang/go#28387

Change-Id: I15cd9408c63f9b6aed50facbfefa26299392052f
Reviewed-on: https://go-review.googlesource.com/c/text/+/208123


Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

internal/gen/gen.go: build tags manually updated

Generation was without issues.

Change-Id: I280fe3aac73e4e52f61f96f625f69a1218eba794
Reviewed-on: https://go-review.googlesource.com/c/text/+/204497

Reviewed-by: Russ Cox <rsc@golang.org>

Fixes golang/go#32844

Change-Id: I9d5364df4f827db4de3c144a565c1d05d8a181bd
Reviewed-on: https://go-review.googlesource.com/c/text/+/192325


Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>

Change-Id: If3becd77d77285bce5e39aa211ea48710b52ef46
Reviewed-on: https://go-review.googlesource.com/c/text/+/192324


Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>

by running go generate at the top level.

IDNA still uses the old test format. The new
format tests more cases. The 11 format causes
test failure, but only for erroneous input that
result in errors. The package will in all such
cases still report an error, but the value result
may differ.

Updates golang/go#27945

Change-Id: Idb94e78411c2cb9f8e829b09d3d8de7807829076
Reviewed-on: https://go-review.googlesource.com/c/text/+/154442


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

Updates documentation and other changes not related to
a Unicode upgrade to minimize the diff.

This CL also updates gen.go to no longer copy packages
into the vendor directory. Henceforth, go mod vendor
should be used to copy packages.

Updates golang/go#27945

Change-Id: I59da1c56e81bec67979ce13d89af3a753d4809aa
Reviewed-on: https://go-review.googlesource.com/c/text/+/169637


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

Prepare for Unicode 11, where in some cases
an undefined title case is lower case, instead of
upper case.

Updates golang/go#27945

Change-Id: I96d6921434e344271c80dbc4033b5952b8284178
Reviewed-on: https://go-review.googlesource.com/c/text/+/169640


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

The limit for this will be reached by Unicode 11.

Updates golang/go#27945

Change-Id: I5add868e60ba632de61b1ff3cb520453759b95c4
Reviewed-on: https://go-review.googlesource.com/c/text/+/169639


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

This is to replace the script test in core that is used
to verify the generation, but it interupts the flow of
automation as they require manual upgrades.
This brute-force approach is better anyway.

Updates golang/go#27945

Change-Id: Ie7b8b257408c790c5547f03747fddc77c6c4ad68
Reviewed-on: https://go-review.googlesource.com/c/text/+/169638


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

by using x/text’s infrastructure

Updates golang/go#27945

Change-Id: I070afd9cad4e367ac9085a66064f2bb47e5e225a
Reviewed-on: https://go-review.googlesource.com/c/text/+/154443


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

Change-Id: I5194e58a7679e33555856a413f6081fea26d8e34
Reviewed-on: https://go-review.googlesource.com/c/text/+/171277

Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

It fails on a bunch of builders and it's not clear what it's testing.

It hasn't been fixed since Oct 2016 so it gets disabled.

Updates golang/go#17538

Change-Id: I0f454c46b31b8306cc604c36ec6d06cc6ad703b5
Reviewed-on: https://go-review.googlesource.com/c/text/+/170783


Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

in preparation to deal with the new file format
in Unicode 11.

Updates golang/go#27945

Change-Id: I424b3891e852c87bea536646a98a96aae2446294
Reviewed-on: https://go-review.googlesource.com/c/text/+/154441


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

automatically update build tags
option to skip tests

Change-Id: Ic1e40c1a8308ed3641ba219a6e55b76dee98581f
Reviewed-on: https://go-review.googlesource.com/c/text/+/154440


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

Change-Id: Ia5a915d14150465a916fd8fde1490794a60348ae
Reviewed-on: https://go-review.googlesource.com/c/text/+/165757


Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

This was broken during the refactoring.

Change-Id: Ied2b144e2f134ec71d20dbb6c0a919941f0bd6eb
Reviewed-on: https://go-review.googlesource.com/c/163317


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ross Light <light@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

This is used to update tables in core unicode.

Change-Id: I6fb34eba45842e38426b1ca54e79b74c361195ec
Reviewed-on: https://go-review.googlesource.com/c/154439


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

Changes:
src/vendor/golang_org moved to src/internal/x

Change-Id: I3791fd633534f15f5e2698ad01ae8d226128181e
Reviewed-on: https://go-review.googlesource.com/c/154438


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ross Light <light@google.com>

copying core's unicode/maketables.go into x/text
in preparation for rework

Copied from master at
26985ed4a58665d25a256e3b63b353972fc3aab0

Change-Id: I343366e69081fb2dbd6030b403386aeae1b0f6d8
Reviewed-on: https://go-review.googlesource.com/c/154437


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ross Light <light@google.com>

Since *ssa.Call implements ssa.Instruction, it should
go before interface case inside a type switch, otherwise
control will never reach it and *ssa.Call values would
enter ssa.Instruction case bodies.

Change-Id: I8d62dc0eb13cdc922df7dfd8a6083ec841542cf0
Reviewed-on: https://go-review.googlesource.com/c/153399


Run-TryBot: Iskander Sharipov <quasilyte@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

i.p is overwritten by setDone, so must be saved before
calling it.

Fixes golang/go#20710

Change-Id: I5744687c11f0c1101712bb5aa290ebe009ff6d05
Reviewed-on: https://go-review.googlesource.com/c/145559


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ross Light <light@google.com>

In some cases the ErrShortDst error was
eroneously overriden by ErrShortSrc.

Fixes golang/go#24170.

Change-Id: I07dd160de045474e8e38506b6793a1da0df6283d
Reviewed-on: https://go-review.googlesource.com/c/145558


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ross Light <light@google.com>

Fixes golang/go#25603

Change-Id: Ie94650ed2579619abfdbbc7410c2f400dec88b25
Reviewed-on: https://go-review.googlesource.com/c/145437


Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Ross Light <light@google.com>

Change-Id: I75fed8f43aa08a780adf0027d86abebf710e9716
GitHub-Last-Rev: 9e3fe5921437ca6c7dff5fa115f4ff494d649bef
GitHub-Pull-Request: golang/text#4
Reviewed-on: https://go-review.googlesource.com/c/145358

Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

Change-Id: I13075dd928617bd81ca519d29984fbb188cb9e60
Reviewed-on: https://go-review.googlesource.com/c/136655

Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

Change-Id: I8389065aaccc59141e79f75ea43343a195fd3bae
Reviewed-on: https://go-review.googlesource.com/134255

Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

Change-Id: I7a2aa7e263aeafa7703f989b78e1333bf5dd8330
Reviewed-on: https://go-review.googlesource.com/133935


Run-TryBot: Sam Whited <sam@samwhited.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>

Follow-up to CL 127926.

The recompMap map is only used by func combine, which only has one
caller. Move the sync.Once.Do call that populates the map out of func
combine up to its sole caller.

I wasn't actually able to measure a difference with this, but
it seems better to do one-time work outside of a loop.

And I verified that combine is still inlined, even with the nil check+panic.

./composition.go:501:24: inlining call to combine

Change-Id: I6929af1de5f068051ef00cf0938b880ff87e1ce4
Reviewed-on: https://go-review.googlesource.com/128575


Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Kevin Burke <kev@inburke.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

Fixes golang/go#26897

Change-Id: Ie47e648f02f2b1ed20e72ab6a05035f91e4635fc
Reviewed-on: https://go-review.googlesource.com/128795

Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

The default indentation for maps changed in a recent Go commit. Rerun
"go generate" for these packages to update the tables to match.

Also add the "replacement" key to the list of encodings retrievable
by Get. It is described in the W3C specification as "[existing] to
prevent certain attacks that abuse a mismatch between encodings
supported on the server and the client."

Change-Id: I3c671c229d1e68721d109364aaf19021bbd3af89
Reviewed-on: https://go-review.googlesource.com/127923

Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

recompMap gets populated on init, which requires 21kB of memory.
Instead populate it only when we need it.

This will put it in the rodata section of the binary, which means that
the Go compiler can apply better optimizations to it. The string is an
alternating series of 4 byte keys and 4 byte values, which get built
into a map the first time they are required.

Updates golang/go#26752.

Change-Id: I4f9b7d74af6df42b58999cf42cf5ada9646aa98d
Reviewed-on: https://go-review.googlesource.com/127926


Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

Add documentation for the "update" command and fix the documentation
to consistently reference the "gotext" binary, not the "go" binary.
This means "go generate ./..." no longer generates a Git diff.

Change-Id: Ic7eb8c5cb3578efbf1f4ebc03ace8155c70cba8c
Reviewed-on: https://go-review.googlesource.com/127922

Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

The latest version of stringer uses strconv instead of fmt as it's
slightly faster.

Change-Id: Ia956eea144f9cab22e4d621af5bb896cd21b9bb0
Reviewed-on: https://go-review.googlesource.com/127921

Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

Those domains are available over HTTPS and we should use them to
ensure privacy and message integrity, particularly in the cases where
we are updating the Unicode table.

Change-Id: I861aa1f581034a762e201ba07faf0e106d231eb3
Reviewed-on: https://go-review.googlesource.com/127918


Run-TryBot: Kevin Burke <kev@inburke.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

Fixes golang/go#26766

Change-Id: I43ad2deb0a55f2c18c820f7885fa9eee4b0e6cd4
Reviewed-on: https://go-review.googlesource.com/127551


Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Iskander Sharipov <iskander.sharipov@intel.com>
Reviewed-by: roger peppe <rogpeppe@gmail.com>

Correct repo name in README.md. Correct binary name in gotext
documentation.

Change-Id: I9541fe023e52be8332d0500934fbe77c353d6cb6
Reviewed-on: https://go-review.googlesource.com/122469

Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

This is a followup to CL 113816. That CL added identical new code to
enforce10.0.0_test.go and enforce9.0.0_test.go, but didn't import new
packages in the latter file. This CL fixes that. As a result, package
tests now pass in Go 1.9.

Updates golang/go#24885.

Change-Id: I0286d873b7f3239bce1a151570c4f9c7ac0219c1
Reviewed-on: https://go-review.googlesource.com/121359

Reviewed-by: Sam Whited <sam@samwhited.com>
Reviewed-by: Dominik Honnef <dominik@honnef.co>